Open
Conversation
Vivelapaix
reviewed
May 17, 2020
linked-list.md
Outdated
| :rtype: ListNode | ||
| """ | ||
|
|
||
| if head and head.next: |
Owner
Author
There was a problem hiding this comment.
Но это не критично. Условие проверяется за O(1)
There was a problem hiding this comment.
Тогда можно вставить еще 10000000000 if, что тоже не критично ? Как изменится быстродействие программы?
Owner
Author
There was a problem hiding this comment.
Условие здесь необходимо, потому что если входные данные: [], то получаем ошибку:
AttributeError: 'NoneType' object has no attribute 'next'
if head.next:
Line 13 in reverseList (Solution.py)
ret = Solution().reverseList(param_1)
Line 45 in _driver (Solution.py)
_driver()
Line 55 in <module> (Solution.py)
There was a problem hiding this comment.
Теперь ты убедился, что в условии нет необходимости
Vivelapaix
approved these changes
May 22, 2020
Vivelapaix
left a comment
Vivelapaix
left a comment
There was a problem hiding this comment.
Теперь с именованием порядок.
Надеюсь, это не с моего гитхаба взято за основу, но даже в таком случае, нет ничего плохого :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.